virtualbox-ose 6.1.50_1

Thes is ~430-640 files, ~30-55MB total for different platforms.
We are using devel/kBuild for build VirtualBox ports.
devel/kBuild is a newer version than the one included in the VirtualBox
tarballs.

Upstream EOL reaches on 2024-01-31, use emulators/virtualbox-ose-*-72
instead.

PR:	290507

PR:	289019

After commit
https://github.com/freebsd/freebsd-src/commit/93b4a54456589e78dcd37f2db8333baff3f3f0b2
  kernel: linker_load_file: /boot/modules/vboxnetflt.ko - unsupported file type
  kernel: KLD vboxnetflt.ko: depends on netgraph - not available or version mismatch

Thanks to Benjamin Close <Benjamin.Close@clearchain.com> and
rkoberman@gmail.com for researching the issue and identifying its cause.

PR:	286204 286717
MFH:	2025Q2

For cross building the CC variable is passed quoted with the target

the which configure script from VirtualBox expects it to only be the
name of the command and using which to determine if usable.

Replacing in the which_wrapper function the call of $* with only the
first argument, makes it accept cross building.

Cross building support is important for kmods as they are all cross
built to populate the kmods repositories

PR:	284439

PR:	271146

If the MAXCPU option is not the default for the running kernel, then
'kldload vboxdrv.ko' will result in a kernel panic.
Due to ABI difference (vboxdrv passes cpuset_t parameter (bitfield with
CPU_SETSIZE -> MAXCPU bits) into smp_rendezvous_cpus()) kernel panics
with "ncpus is 0 with non-zero map" message.

PR:	219913

* Replace PORTVERSION with DISTVERSION.
* Fix CONFLICTS_INSTALL.
* Fix PYTHON in DEFAULT_OPTIONS in emulators/virtualbox-ose.
* Pet portclippy and portlint.
* Formatting and etc.

PR:	258159

Changelog: https://www.virtualbox.org/wiki/Changelog-6.1#v50

PR:			276437
Approved by:		arrowd (mentor), olce
Differential Revision:	https://reviews.freebsd.org/D43510
MFH:			2024Q1

Based on patch from Sergey V. Dyatko <sergey.dyatko@gmail.com>.
Changelog: https://www.virtualbox.org/wiki/Changelog-6.1#v48

PR:			274555
Approved by:		arrowd (mentor)
Differential Revision:	https://reviews.freebsd.org/D42322
MFH:			2023Q4

Changelog: https://www.virtualbox.org/wiki/Changelog-6.1#v46
Also fixed PORTREVISION in master/slave ports.

PR:			272572
Approved by:		arrowd (mentor)
Differential Revision:	https://reviews.freebsd.org/D41110
MFH:			2023Q3

Changes:		https://www.virtualbox.org/wiki/Changelog-6.1#v44
Author:			lwhsu@FreeBSD.org
Note:			BROKEN on 14

PR:			266907
Reported by:		Ian Dickens <ian@south-border.com>
Approved by:		arrowd (mentor), joneum (ports-secteam)
Differential Revision:	https://reviews.freebsd.org/D40088

Commit b7f05445c00f has added WWW entries to port Makefiles based on
WWW: lines in pkg-descr files.

This commit removes the WWW: lines of moved-over URLs from these
pkg-descr files.

Approved by:		portmgr (tcberner)

It has been common practice to have one or more URLs at the end of the
ports' pkg-descr files, one per line and prefixed with "WWW:". These
URLs should point at a project website or other relevant resources.

Access to these URLs required processing of the pkg-descr files, and
they have often become stale over time. If more than one such URL was
present in a pkg-descr file, only the first one was tarnsfered into
the port INDEX, but for many ports only the last line did contain the
port specific URL to further information.

There have been several proposals to make a project URL available as
a macro in the ports' Makefiles, over time.

This commit implements such a proposal and moves one of the WWW: entries
of each pkg-descr file into the respective port's Makefile. A heuristic
attempts to identify the most relevant URL in case there is more than
one WWW: entry in some pkg-descr file. URLs that are not moved into the
Makefile are prefixed with "See also:" instead of "WWW:" in the pkg-descr
files in order to preserve them.

There are 1256 ports that had no WWW: entries in pkg-descr files. These
ports will not be touched in this commit.

The portlint port has been adjusted to expect a WWW entry in each port
Makefile, and to flag any remaining "WWW:" lines in pkg-descr files as
deprecated.

Approved by:		portmgr (tcberner)

Changelog: https://www.virtualbox.org/wiki/Changelog

PR:		265351

Use a more restricted range of supported __FreeBSD_version values for
the virtualbox kernel module since it uses internal KPIs for which KBI
stability is not guaranteed.  DECLARE_MODULE_TIED would tie the module
to a specific __FreeBSD_version which would cause the module to stop
loading when an SA or EN is pushed on a release branch.  Instead, use
DECLARE_MODULE_MAXVER with an upper bound that is limited to the range
of a releng branch so that a module built on X.Y will load on X.Y with
SAs or ENs applied but will fail to load on X.Y-1 or X.Y+1.

Reviewed by:	kevans, imp, madpilot, lwhsu (earlier version)
Differential Revision:	https://reviews.freebsd.org/D16119

PR:		263439

PR:		262656
Approved by:	madpilot

Changelog: https://www.virtualbox.org/wiki/Changelog-6.1#v32

There have been lots of missing CONFLICTS_INSTALL entries, either
because conflicting ports were added without updating existing ports,
due to name changes of generated packages, due to mis-understanding
the format and semantics of the conflicts entries, or just due to
typoes in package names.

This patch is the result of a comparison of all files contained in
the official packages with each other. This comparison was based on
packages built with default options and may therefore have missed
further conflicts with optionally installed files.

Where possible, version numbers in conflicts entries have been
generalized, some times taking advantage of the fact that a port
cannot conflict with itself (due to logic in bsd.port.mk that
supresses the pattern match result in that case).

A few ports that set the conflicts variables depending on complex
conditions (e.g. port options), have been left unmodified, despite
probably containing outdated package names.

These changes should only affect the installation of locally built
ports, not the package building with poudriere. They should give an
early indication of the install conflict in cases where currently
the pkg command aborts an installation when it detects that an
existing file would be overwritten,

Approved by:	portmgr (implicit)

The conflict checks compare the patterns first against the package
names without version (as reported by "pkg query "%n"), then - if
there was no match - agsinst the full package names including the
version (as reported by "pkg query "%n-%v").

Approved by: portmgr (blanket)

In the commit to update virtualbox-ose to 6.1.28 I made a one line
mistake when reapplying a patch which failed to apply as is.

In the patch
files/patch-src_VBox_HostDrivers_Support_freebsd_SUPDrv-freebsd.c
I did not replay a part removing the line:

rc = copyout(pHdr, pvUser, cbOut);

which was rewriting some data that it should not. The correct code
was anyway present after this leftover statement.

This error made virtualbox log a lot of warnings about Bad CPU
context like this:

vboxdrv: Bad CPU context error at line 373 in SUPDrv-freebsd.c:
ulCmd=0x2000568a: 0x282->0x287!

These seem to be unharmful, but anyway indicate a problem that this
commit fixes.

Reported by:		Kevin Oberman <rkoberman@gmail.com> (via mailing list)
Fixes:			a3db7da59f9498

Changelog: https://www.virtualbox.org/wiki/Changelog

This new version has a regression in the pulseaudio host audio
driver. If enabled any VMs configured to use it fails to start.

Since no fix has been found the PULSEAUDIO option is forcibly
disabled. If you have any VM configured to use pulseaudio for audio
input/output, please reconfigure them to use a different driver.

Upstream ticket:	https://www.virtualbox.org/ticket/20484

Other changes:

- Remove old patches that don't apply, the audio system has been
  reworked upstream and the behavior of these patches is included in
  the new code
- Add upgrading pkg-message note about the PULSEAUDIO option issue
  described above

Reviewed by:		koobs
Differential Revision:	https://reviews.freebsd.org/D31264

After src commit e266a0f7f001 a module is not allowed to call
kern_kldload while being loaded. The virtualbox module is doing
exactly this though. virutalbox used to do this because the ng_ether
netgraph node did not provide version information in the past and
there was no way to properly depend on it.

ng_ether has gained versioning information in base r238844 more
than ten years ago, so we can now unconditionally properly depend
on it, since this revision is now included in all supported FreeBSD
versions.

Thanks to Tomoaki AOKI for identifying the base commuit exposing
the issue.
PR:			256505
Tested by:		Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
MFH:			2021Q2
Differential Revision:	https://reviews.freebsd.org/D30722

- Also update related kmod and additions ports
- In additions, use INSTALL_LIB to install X11 modules, so binaries
  get stripped
- Trim some `#if __FreeBSD_version` checks for unsupported FreeBSD
  versions from patches

PR:		255301

In r560502, I added a patch to support EPOCH to VirtualBox 5. When we upgraded
to VirtualBox 6, that patch was (unintentionally) removed, making it impossible
to use bridge move without this current patch.

Approved by:	jkim, madpilot
Differential Revision:	https://reviews.freebsd.org/D29319

Please note that this new version supports only amd64 CPUs. If you need
to use older hardware please install the legacy ports.

Note that moving VM snapshots across major updates is unsupported, it's
strongly suggested to properly shutdown VMs before upgrading, please
check UPDATING for further details.

This update is the result of work from many people, and thanks to all
who gave feedback and tested things.

Patch based on work from: Mario Lobo <lobo@bsd.com.br> and jkim.

PR:			234878
Submitted by:		kunda <chitty_cloud@me.com>
Approved by:		vbox (implicit)
Reviewed by:		decke
Tested by:		jwb,
			martin ilavsky <ilavsky.martin@gmail.com>,
			Mario Lobo <lobo@bsd.com.br>
Relnotes:		https://www.virtualbox.org/wiki/Changelog-6.1
Differential Revision:	https://reviews.freebsd.org/D28871

Reviewed by:		kp, jkim (previous version)
Approved by:		kp, jkim (previous version), 0mp (mentor)
Differential Revision:	https://reviews.freebsd.org/D26359

- Use vm_pager_allocate() to allocate OBJT_PHYS objects.  This ensures
  that they're initialized properly.
- Don't assume that user wiring will succeed.

This had been a team effort, with multiple independent reports,
a wide variety of experiments, and patches written by kib@
and refined by markj@.

I'm bumping PORTREVISION and aligning the revision of both kmod and
application; it's possible the application bump isn't actually
needed but let's make sure they both get rebuilt with this
important (because of changed kernel assumptions) fix.

PR:		249326
Submitted by:	kib, markj
Reported by:	adridg, Rainer Hurling
Reviewed by:	adridg
Approved by:	koobs (vbox)
MFH:		2020Q3

Patch based on one provided by Mario Lobo <lobo@bsd.com.br>.

Many thanks to people who provided ideas and suggetions in the
PR and review.

PR:			244212
Submitted by:		Nikita Stepanov <nikitastepan0v@bk.ru>
Reviewed by:		kevans [1]
Tested by:		lwshu
Approved by:		ports-secteam (joneum)
MFH:			2020Q3
Security:		1e7b316b-c6a8-11ea-a7d5-001999f8d30b
Differential Revision:	https://reviews.freebsd.org/D25496

extrapatch-Config.kmk was merged in ports r528258 into the standard
Config.kmk patch out of necessity, but inadvertently missed that it was also
referenced in two other spots.

No PORTREVISION bump, as these are build-only fixes to fix the entirety of
virtualbox-ose-additions and the DEBUG option of virtualbox-ose-kmod.

PR:		245239
Approved by:	koobs (mentor)
Approved by:	portmgr (blanket: build fix, just-fix-it)
MFH:		2020Q2 (blanket: build fix)
Differential Revision:	https://reviews.freebsd.org/D24260

https://www.virtualbox.org/wiki/Changelog-5.2#v34

Approved by:	portmgr blanket

- Unbreak `make -s` builds

PR:		240433, 240426
Submitted by:	Franco Fichtner <franco@opnsense.org> (based on)

This includes ports
 - with USE_GCC=yes or USE_GCC=any,
 - with USES=fortran,
 - using Mk/bsd.octave.mk which in turn features USES=fortran, and
 - with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
   c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, everything INDEX-11 shows with a dependency on lang/gcc9 now.

PR:		238330

https://www.virtualbox.org/wiki/Changelog-5.2#v32

https://www.virtualbox.org/wiki/Changelog-5.2#v30

The SSL certificate of the host does not have download.virtualbox.org
in it's SubjectAltName anymore (download.virtualbox.org points to the
same CDN and is the same host as download.oracle.com, and checksums still
match).

Reported by:	Duncan Young

https://www.virtualbox.org/wiki/Changelog-5.2#v28