bitcoin 30.2

This is a larger than recent releases with an update to Qt6 and dropping
of the legacy BDB wallet format.  See previous UPDATING message if you
need wallet migration instructions; the conversion code is integrated
and does not need BDB.

Get rid of direct dependency ob libbost_system.so, use libboost_thread.so instead

IMPORTANT:
29.x is the last release series that will support the legacy BDB wallet
format.  We are already doing this awkwardly since the format is BDB 4.8
and we are building with BDB 5.  This will be removed in 30.0 later this
year.

Instructions:
https://github.com/bitcoin/bitcoin/blob/29.x/doc/managing-wallets.md#migrating-legacy-wallets-to-descriptor-wallets

This release switches to CMake which results in a major refacoring of
the port and underlying build.  The result seems good, but please
provide feedback if there are any unexpected changes or problems.

This release dropped UPnP support due to security concerns.  NAT-PMP is
implemented as an alternative.

Reviewed by:	arrowd (previous revision)
Differential Revision:	https://reviews.freebsd.org/D50265

Sponsored by:	Future Crew, LLC

Sponsored by:	Future Crew, LLC

With hat:	office
Sponsored by:	Future Crew, LLC

Approved by:	portmgr (blanket)

Changes https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-25.0.md

Sponsored by:	BBOX.io

Changes: https://bitcoincore.org/en/releases/24.0.1/

PR:	246106

Sponsored by:	BBOX.io

In r465909 [1], 2 years ago, we added the option to link
net-p2p/bitcoin* against db 5 or 6, still allowing to link against db
4.8 which is long time EOL and has been deprecated and marked for
deletion in 2014 [2].

Now remove the option to link net-p2p/bitcoin* against db48, so the
former does not depend on the latter anymore and db48 can be eventually
removed from the ports tree.

[1]
https://svnweb.freebsd.org/ports?view=revision&revision=465909
https://github.com/freebsd/freebsd-ports/commit/68892c74876772806eaca3a9ecc1308e9459acea

[2]
https://github.com/freebsd/freebsd-ports/commit/b0113421712e3e2543fa9e1e0726502ef475e372#diff-9385162ec22da88a3a66c47891cbde67R19

PR:		245220
Submitted by:	vd
Approved by:	kbowling (maintainer timeout)

ndoutils needs C11 compiler because it links to mysql libraries.

Approved by:	mentors (implicit approval)

Make the new option the default, so that when the port is recompiled it
will link against BDB 5.x or 6.x (whichever is the default in the system).
This will keep old wallet files readable and will not automatically
convert them in an incompatible with BDB 4.8 way. Newly created wallet
files will not be readable by Bitcoin Core versions linked with BDB 4.8.

Next thing to consider is to remove the option to link against BDB 4.8 as
this will remove the net-p2p/bitcoin -> databases/db48 dependency and will
make it possible to ditch the latter, which is scheduled for removal from
the ports collection on Apr 30 2018.

PR:		226527
Approved by:	kbowling (maintainer), antoine

With hat:	portmgr

In c465619 a new single-choice option was introduced in net-p2p/bitcoin
where exactly one variant must be chosen (BDB version). But the bitcoin
slave ports net-p2p/bitcoin-daemon and net-p2p/bitcoin-utils set
OPTIONS_DEFAULT=... (with missing BDB version) and the master port uses
OPTIONS_DEFAULT?=...somebdbversion... so the choice of the master port
is not inherited by the slaves.

Fix this by explicitly setting the BDB version in both slave ports.

Reported by:	Dan Langille

This will attempt builds on arm platforms on the cluster.

Approved by:	portmgr (tier-2 blanket)

PR:		220897
Submitted by:	kbowling
Approved by:	robbak@robbak.com (maintainer)
Differential Revision:	https://reviews.freebsd.org/D11684

While here, alphabetize ARCHs, pet portlint, and modernize usages.

Approved by:	portmgr (tier-2 blanket)

Changes:	http://www.boost.org/users/history/version_1_64_0.html
PR:		218835
Approved by:	office (bapt)
Exp-run by:	antoine
Differential Revision:	https://reviews.freebsd.org/D10472

PR:		216777
Approved by:	mm (maintainer)

- DEFAULT_VERSIONS += ssl=openssl-devel is now supported
- devel/py-event and devel/p5-Event-Lib are marked BROKEN

Changes:	https://github.com/libevent/libevent/raw/release-2.1.8-stable/whatsnew-2.1.txt
Changes:	https://github.com/libevent/libevent/raw/release-2.1.8-stable/ChangeLog
PR:		216527
Exp-run by:	antoine
Approved by:	mm (maintainer)

Changes:	http://www.boost.org/users/history/version_1_63_0.html
PR:		215598
Exp-run by:	antoine
Approved by:	office (bapt)
MFH:		2017Q1

- Enable `long double` C99 math usage
- Switch 9.x back to building with GCC

Changes:	http://www.boost.org/users/history/
PR:		199601
Submitted by:	Chen Xu, bapt, amdmi3, truckman (based on)
Reviewed by:	rakuco (kde) (earlier version)
Exp-run by:	antoine (3 tries), truckman (consumers only, earlier versions)
Approved by:	bapt (office)

PR:		208937, 209136
Submitted by:	xenophon+fbsdports@irtnog.org [1]
Approved by:	robbak@gmail.com (maintainer)

https://github.com/miniupnp/miniupnp/commit/1da63faa4fff5cb30e5d4b848ceef80a292382b9

PR:		203761
Submitted by:	robbak@gmail.com (based on)
Obtained from:	upstream
MFH:		2015Q4
X-MFH-With:	r399209

Approved by:	portmgr (sparc64 blanket)

- Update to 0.10.0
- Split out bitcoin-cli and bitcoin-tx into net-p2p/bitcoin-utils
- Slave out bitcoin-utils and bitcoin-daemon properly
- Canonicalize MASTER_SITES to what USE_GITHUB uses
- Update COMMENT so each port is unique
- protobuf/protoc is GUI-only dependency, remove it from unconditional
  {BUILD,LIB}_DEPENDS.
- Group and sort USES/USE_*
- Deprecate USE_AUTOTOOLS in favour of USES=autoreconf
- Remove {AUTOMAKE,ACLOCAL}_ARGS accordingly
- Remove unconditional *FLAGS and replace then with OPTIONS-conditional
  ones.
- Remove unnecessary CXXFLAGS
- Add HARDENING and TESTS options, add them to OPTIONS_DEFAULT
- Add DBUS and DEBUG options
- Define OPTIONS only where they're relevant for each port
- Rejig OPTIONS descriptions for greater clarity
- Replace hard-coded SSL inc/lib flags with USE_OPENSSL variables to
  allow for switching between Base and Ports OpenSSL's.
- Use OPTIONS helpers
- Remove post-patch target
- Canonicalize CONFIGURE_ARGS, with slave port specific overrides.
- Verbosify builds (V=1)
- Remove upstreamed patches
- Add regression-test targets (requires TESTS option)
- Add --disable-reduce-exports to CONFIGURE_ARGS until upstream PR #5819
  lands, which caused sanity test failure at run-time [1]

  P.S We now pass the test suite (not including python test, which
      has an error)

Based on patch Submitted by:

 - Andriy Voskoboinyk  <s3erios gmail.com>
 - Robert Backhaus <robbak gmail.com>

[1] https://github.com/bitcoin/bitcoin/pull/5819

PR:		193424
Reviewed by:	maintainer
Approved by:	maintainer